zsh: make profiling .zprofile easier by using functions

config/zsh/.zprofile

@@ -1,4 +1,5 @@
 # General environment settings.
+setup_environment() {
   export XDG_CACHE_HOME="${XDG_CACHE_HOME:-$HOME/.cache}"
   export XDG_CONFIG_HOME="${XDG_CONFIG_HOME:-$HOME/.config}"
   export XDG_DATA_HOME="${XDG_DATA_HOME:-$HOME/.local/share}"
@@ -16,6 +17,7 @@ export LESSHISTSIZE=1000
   export LOCAL_PREFIX="/usr/local"
   export PAGER=less
   export PYTHONSTARTUP="$XDG_CONFIG_HOME/python/startup.py"
+}
 
 have() {
   command -v "$1" >/dev/null 2>&1
@@ -29,7 +31,9 @@ have() {
 #
 #   For details see: https://superuser.com/a/583502
 #
+setup_macos_path_helper() {
   [ "$(uname -s)" = "Darwin" ] && { PATH=""; source /etc/profile; }
+}
 
 # Prepend $2 to variable $1 using $3 as separator, but only if $2 is not already
 # contained in $1. This is useful for prepending to PATH while avoiding
@@ -53,6 +57,8 @@ prepend_unique() {
 }
 
 # Add custom bin dirs to PATH if they exist and are not already in PATH.
+setup_path() {
+  local dir=""
   while read -r dir; do
     [ -d "$dir" ] && prepend_unique PATH "${dir}"
   done <<EOL
@@ -67,15 +73,18 @@ done <<EOL
     $HOME/.local/bin
     $HOME/.bin
 EOL
-export PATH
+}
 
 # Prepend custom man directories to MANPATH if they exist, so that we get
 # correct man page entries when multiple versions of a command are
 # available.
-have manpath && MANPATH="$(unset MANPATH; manpath)"
+setup_manpath() {
+  local dir=""
+  # TODO: check if I really need the next line, `manpath` add ~600ms to startup
+  # have manpath && MANPATH="$(unset MANPATH; manpath)"
   while read -r dir; do
     [ -d "$dir" ] && prepend_unique MANPATH "${dir}"
-done <<EOL
+  done <<-EOL
     $LOCAL_PREFIX/share/man
     $LOCAL_PREFIX/opt/curl/share/man
     $LOCAL_PREFIX/opt/make/libexec/gnuman
@@ -86,13 +95,11 @@ done <<EOL
     $LOCAL_PREFIX/opt/coreutils/libexec/gnuman
     $HOME/.local/share/man
 EOL
-export MANPATH
-
-unset dir
+}
 
 # These checks have to be done after PATH manipulation above so we can find
 # installed programs if they are in the added paths.
-
+setup_tools() {
   have nvim && EDITOR="nvim"
   [ -z $EDITOR ] && have vim && EDITOR="vim"
   [ -z $EDITOR ] && have vi && EDITOR="vi"
@@ -107,21 +114,34 @@ have dotnet && {
     export DOTNET_CLI_TELEMETRY_OPTOUT=1
     export DOTNET_NOLOGO=1
   }
+}
 
 # Set $DISPLAY if running in WSL and an Xserver is reachable
 #
 # How to configure Windows Firewall for Xserver: https://skeptric.com/wsl2-xserver/
 # How to check if running in WSL: https://stackoverflow.com/a/61014411
-if [ -n "$(uname -r | sed -n 's/.*\( *Microsoft *\).*/\1/ip')" ]; then
-  xdisplay="$(awk '/nameserver/ {print $2; exit}' /etc/resolv.conf 2>/dev/null):0.0"
-  have xset && if DISPLAY="$xdisplay" timeout '0.2s' xset q >/dev/null 2>&1; then
+setup_wsl_display() {
+  if [ -n "$(uname -r | sed -n 's/.*\( *Microsoft *\).*/\1/ip')" ] && have xset; then
+    local xdisplay="$(awk '/nameserver/ {print $2; exit}' /etc/resolv.conf 2>/dev/null):0.0"
+    if DISPLAY="$xdisplay" timeout '0.2s' xset q >/dev/null 2>&1; then
       export DISPLAY="$xdisplay"
       export LIBGL_ALWAYS_INDIRECT=1
     fi
-  unset xdisplay
   fi
+}
 
 # Load additional local configuration if present.
-local_profile="$HOME/.local/etc/zsh/zprofile"
-[ -r "$local_profile" ] && source "$local_profile"
-unset local_profile
+setup_local_profile() {
+  local profile="$HOME/.local/etc/zsh/zprofile"
+  [ -r "$profile" ] && source "$profile"
+}
+
+# zmodload zsh/zprof
+setup_environment
+setup_macos_path_helper
+setup_path && export PATH
+setup_manpath && export MANPATH
+setup_tools
+setup_wsl_display
+setup_local_profile
+# zprof